[ 
https://issues.apache.org/jira/browse/CASSANDRA-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659555#comment-14659555
 ] 

Stefania commented on CASSANDRA-9978:
-------------------------------------

I've noticed some more problems when scrubbing with an offline transaction: we 
need to release the references of the new sstables or we have LEAK errors. 
testScrubOutOfOrder should no longer release a reference to the old table (now 
done by the transaction) and it should wait for deletions before loading the 
new sstables (same race as in CASSANDRA-9908).

Further, BigTableWriterTest was also broken by CASSANDRA-7066 in that the 
commit method of SSTableTxnWriter can throw (since LifecycleTransaction can) 
and so we should declare it in the test. In addition, SSTableTxnWriter should 
call txn.commit() before writer.commit() since the former may throw. I am going 
to fix these two things as well here if that's OK.

3.0 patch [here|https://github.com/stef1927/cassandra/commits/9978-3.0].

CI still pending:

http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9978-3.0-testall/
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9978-3.0-dtest/

> Split/Scrub tools no longer remove original sstable
> ---------------------------------------------------
>
>                 Key: CASSANDRA-9978
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9978
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: T Jake Luciani
>            Assignee: Stefania
>            Priority: Minor
>             Fix For: 3.0 beta 1
>
>
> Looks like CASSANDRA-7066 broke the scrub and split tools.  The orig sstable 
> is no longer removed.
> I fixed the sstablesplit dtest so you should see the issue now.  The max 
> sstable size doesn't match expected because it's the original 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to