[ 
https://issues.apache.org/jira/browse/CASSANDRA-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679545#comment-14679545
 ] 

Stefania commented on CASSANDRA-10015:
--------------------------------------

LGTM so far. 

Some questions / suggestions:

* Do we need a Windows script and why do we have some sstable* scripts in bin 
and some in tools/bin?

* In the documentation at the top of SSTableExpiredBlocker I would reference 
the ticket number and perhaps explicitly spell out how an sstable can block 
expired sstables, rather than just limiting it to "cover anything in other 
sstables". Something like what's mentioned in this ticket description would 
maybe be a little clearer.

* I would replace _columnfamily_ with _table_, at least in the usage and error 
messages.

> Create tool to debug why expired sstables are not getting dropped
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-10015
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10015
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 3.x, 2.1.x, 2.0.x, 2.2.x
>
>
> Sometimes fully expired sstables are not getting dropped, and it is a real 
> pain to manually find out why.
> A tool that outputs which sstable blocks (by having older data than the 
> newest tombstone in an expired sstable) expired ones would save a lot of time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to