[ 
https://issues.apache.org/jira/browse/CASSANDRA-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682483#comment-14682483
 ] 

Ariel Weisberg commented on CASSANDRA-9932:
-------------------------------------------

+1. Make sure to file and link a ticket to CASSANDRA-9012.

Hand copied combination of BTreeTest and LongBTreeTest.
||Element|      Cov.||
|builder(Comparator, int)|      0%|
|build(Iterable, UpdateFunction)|       0%|
|singleton(Object)|     0%|
|slice(Object[], Comparator, Object, Object, BTree.Dir)|        0%|
|equals(Object[], Object[])|0%|
|depth(Object[])|0%|
|merge(Object[], Object[], Comparator, UpdateFunction)|0%|
|hashCode(Object[])|0%|
|sizeOfStructureOnHeap(Object[])|0%|
|find(Object[], Comparator, Object)|0%|
|replaceInSitu(Object[], Comparator, Object, Object)|0%|
|slice(Object[], Comparator, Object, boolean, Object, boolean, BTree.Dir)|0%|
|build(Iterable, int, UpdateFunction)|54%|
|treeIndexOfKey(Object[], int)| 63%|
|findByIndex(Object[], int)|71%|
|compare(Comparator, Object, Object)|81%|

> Make all partitions btree backed
> --------------------------------
>
>                 Key: CASSANDRA-9932
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9932
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>             Fix For: 3.0.0 rc1
>
>
> Following on from the other btree related refactors, this patch makes all 
> partition (and partition-like) objects backed by the same basic structure: 
> {{AbstractBTreePartition}}. With two main offshoots: 
> {{ImmutableBTreePartition}} and {{AtomicBTreePartition}}
> The main upshot is a 30% net code reduction, meaning better exercise of btree 
> code paths and fewer new code paths to go wrong. A secondary upshort is that, 
> by funnelling all our comparisons through a btree, there is a higher 
> likelihood of icache occupancy and we have only one area to focus delivery of 
> improvements for their enjoyment by all.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to