[
https://issues.apache.org/jira/browse/CASSANDRA-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694306#comment-14694306
]
Aleksey Yeschenko commented on CASSANDRA-9265:
----------------------------------------------
Attaching two patches (for 2.2 and for 3.0) that slap a
{{@SuppressWarnings("resource")}} where necessary. Also fix
{{CorruptFileException}} constructor ignoring {{cause}} and some missing
{{@Override}}. Didn't pay attention on commit since I wasn't the reviewer,
sorry.
> Add checksum to saved cache files
> ---------------------------------
>
> Key: CASSANDRA-9265
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9265
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Ariel Weisberg
> Assignee: Daniel Chia
> Fix For: 2.2.1, 3.0 beta 1
>
> Attachments:
> 0001-Add-checksum-to-saved-cache-files-CASSANDRA-9265.patch,
> 0002-trunk-CASSANDRA-9265.patch, 9265-2.2.txt, 9265-3.0.txt
>
>
> Saved caches are not covered by a checksum. We should at least emit a
> checksum. My suggestion is a large checksum of the whole file (convenient
> offline validation), and then smaller per record checksums after each record
> is written (possibly a subset of the incrementally maintained larger
> checksum).
> I wouldn't go for anything fancy to try to recover from corruption since it
> is just a saved cache. If corruption is detected while reading I would just
> have it bail out. I would rather have less code to review and test in this
> instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
