[ 
https://issues.apache.org/jira/browse/CASSANDRA-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696932#comment-14696932
 ] 

Benedict commented on CASSANDRA-9500:
-------------------------------------

Just an FYI that, interestingly, my changes caused a long standing (but 
difficult to encounter) bug to be elicited, i.e. if the buffer is full when you 
take a {{mark()}} of a compressed buffer, {{resetAndTruncate}} will not behave 
correctly. A trivial fix is to flush in {{mark()}} if we're full, and I've 
force pushed this.

> SequentialWriter should extend BufferedDataOutputStreamPlus
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-9500
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9500
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Benedict
>            Assignee: Ariel Weisberg
>            Priority: Minor
>
> SequentialWriter is the last piece left not implementing 
> DataOutputStreamPlus. It should not be too tricky to extend it, and it should 
> result in improved write throughput. Further, it will permit it to exploit 
> the more efficient implementation of writeVInt being delivered in 
> CASSANDRA-9499



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to