[ 
https://issues.apache.org/jira/browse/CASSANDRA-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704729#comment-14704729
 ] 

Marcus Eriksson commented on CASSANDRA-8671:
--------------------------------------------

This is basically ready to commit now, just 2 comments

* A bit worried about the CQLSSTableWriter change to create the cfs if it does 
not exist - could we instead create a default SSTableMultiWriter for the 
SSTableTxnWriter and avoid creating the CFS instance? (something like this: 
https://github.com/krummas/cassandra/commit/acb133e99d464aba73f14a405e9ca7115fd24500)?
* setInitialDirectories in ColumnFamilyStore is unused - is it needed?

> Give compaction strategy more control over where sstables are created, 
> including for flushing and streaming.
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8671
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8671
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>             Fix For: 3.x
>
>         Attachments: 
> 0001-C8671-creating-sstable-writers-for-flush-and-stream-.patch, 
> 8671-giving-compaction-strategies-more-control-over.txt
>
>
> This would enable routing different partitions to different disks based on 
> some user defined parameters.
> My initial take on how to do this would be to make an interface from 
> SSTableWriter, and have a table's compaction strategy do all SSTableWriter 
> instantiation. Compaction strategies could then implement their own 
> SSTableWriter implementations (which basically wrap one or more normal 
> sstablewriters) for compaction, flushing, and streaming. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to