[
https://issues.apache.org/jira/browse/CASSANDRA-8611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713056#comment-14713056
]
Benjamin Lerer commented on CASSANDRA-8611:
-------------------------------------------
Thanks for the patch.
* the results for the unit tests for 2.1 are
[here|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-8611-2.1-testall/lastCompletedBuild/testReport/]
* the results for the dtests for 2.1 are
[here|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-8611-2.1-dtest/lastCompletedBuild/testReport/]
* the results for the unit tests for 2.2 are
[here|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-8611-2.2-testall/lastCompletedBuild/testReport/]
* the results for the dtests for 2.2 are
[here|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-8611-2.2-dtest/lastCompletedBuild/testReport/]
* the results for the unit tests for 3.0 are
[here|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-8611-3.0-testall/lastCompletedBuild/testReport/]
* the results for the dtests for 3.0 are
[here|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-8611-3.0-dtest/lastCompletedBuild/testReport/]
LGTM
> give streaming_socket_timeout_in_ms a non-zero default
> ------------------------------------------------------
>
> Key: CASSANDRA-8611
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8611
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Robert Coli
> Fix For: 2.1.x
>
> Attachments:
> CASSANDRA-8611.streaming_socket_timeout_in_ms.default.to.an.hour.against.2.1.patch,
>
> CASSANDRA-8611.streaming_socket_timeout_in_ms.default.to.an.hour.against.trunk.patch
>
>
> Sometimes as mentioned in CASSANDRA-8472 streams will hang. We have
> streaming_socket_timeout_in_ms which can retry after a timeout. It would be
> good to make a default non-zero value. We don't want to paper over problems,
> but streams sometimes hang and you don't want long running streaming
> operations to just fail - as in repairs or bootstraps.
> streaming_socket_timeout_in_ms should be based on the tcp idle timeout so it
> shouldn't be a problem to set it to on the order of minutes. Also the socket
> should only be open during the actual streaming and not during operations
> such as merkle tree generation. We can set it to a conservative value and
> people can set it more aggressively as needed. Disabling as a default, in my
> opinion, is too conservative.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
