[ 
https://issues.apache.org/jira/browse/CASSANDRA-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717036#comment-14717036
 ] 

Benedict commented on CASSANDRA-10045:
--------------------------------------

OK, AFAICT it's GTG now.

[dtests|http://cassci.datastax.com/job/belliottsmith-10045-dtest/20/#showFailuresLink]
 do have a slightly higher failure count than current 3.0, but they all seem to 
be related to existing failures, and I can't see the avenue by which they would 
be directly caused by this patch. It's possible the extra compressed commit log 
segment tests failures are, but I'm not 100% sure what they're trying to 
achieve. If they have an expectation of hitting a certain compression ratio, 
this may possibly impair that by making the data less compressible. Perhaps 
someone from Test Engineering can take a look?

> Sparse/Dense decision should be made per-row, not per-file
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-10045
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10045
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>             Fix For: 3.0 beta 2
>
>
> Marking this as beta 1 in the hope I have time to rustle it up and get it 
> reviewed beforehand. If I do not, I will let it slide, but our behaviour 
> right now is not brilliant for workloads with a variance in density, and it 
> should not be challenging to make a more targeted decision.
> We can also make use of CASSANDRA-9894 to make column encoding more efficient 
> in many, even dense, cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to