[ 
https://issues.apache.org/jira/browse/CASSANDRA-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725544#comment-14725544
 ] 

Sylvain Lebresne commented on CASSANDRA-10232:
----------------------------------------------

bq. LegacySSTableTest fails

Yeah, forgot to mention that. That's actually just a new manifestation of 
CASSANDRA-10136. Basically, we used to instantiate the index entry deserializer 
on every actual use, and so the exception of CASSANDRA-10136 (which just means 
some code is missing) was only triggered if an old sstable actually had an 
indexed entry. The 3rd patch here however moves the initialization sooner (with 
the benefit that it's initialized only once) but that means the exception is 
thrown for any old sstable, even if it doesn't actually have an indexed 
partition. I've checked that CASSANDRA-10136 does fix this for this branch but 
I'm happy to wait on that latter issue to be committed before committing this 
if that makes people more comfortable.

> Small optimizations in index entry serialization
> ------------------------------------------------
>
>                 Key: CASSANDRA-10232
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10232
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 3.0.0 rc1
>
>
> While we should improve the data structure we use for our on-disk index in 
> future versions, it occurred to me that we had a few _very_ low hanging fruit 
> optimization (as in, for 3.0) we could do for the serialization of our 
> current entries, like using vint encodings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to