[
https://issues.apache.org/jira/browse/CASSANDRA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylvain Lebresne updated CASSANDRA-1936:
----------------------------------------
Attachment: 0001-Put-partitioned-counter-directly-in-column-value.patch
Patch attached, a few comments:
* since this patch stuffs the context in the column value, who are
ByteBuffers, a good part of this patch deals with adapting the functions
of CounterContext to take and return ByteBuffers instead of plain byte[].
* the patch also corrects a few not completely related misuse of absolute
ByteBuffer's gets. Namely, there was a few occurrences where arrayOffset
was wrongly added to the provided index, like: bb.getLong(bb.position() +
bb.arrayOffset()).
* this patch breaks the on-disk file format. Since #1937 and #1938 will do
too, I'm fine with waiting that both are ready to commit all the 3 patches
together (I'm hoping to tackle these patches quickly).
> Fit partitioned counter directly into CounterColumn.value
> ----------------------------------------------------------
>
> Key: CASSANDRA-1936
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1936
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Fix For: 0.8
>
> Attachments:
> 0001-Put-partitioned-counter-directly-in-column-value.patch
>
>
> The current implementation of CounterColumn keeps both the partitioned
> counter and the total value of the counter (that is, the sum of the parts of
> the partitioned counter).
> This waste space and this requires the code to keep both representation in
> sync. This ticket propose to remove the total value from the representation
> and to only calculate it when returning the value to the client.
> NOTE: this breaks the on-disk file format (for counters)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
