[
https://issues.apache.org/jira/browse/CASSANDRA-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729052#comment-14729052
]
Marcus Eriksson commented on CASSANDRA-10193:
---------------------------------------------
bq. we should consider if we want an expiry date on the assertion
Agree - update the comment above it and perhaps a TODO item to remove eventually
First read through, looks good, pushed a commit
[here|https://github.com/krummas/cassandra/commits/bes/10193] that:
* removes unused imports
* remove a few unused parameters in MemtableAllocator#rowBuilder (note, if you
foresee that we need those when implementing NativeAllocator, ignore this)
* removes unused Column parameter in a couple of places
Could you rebase and I'll have a second pass over this?
> Improve Rows.diff and Rows.merge efficiency; downgrade Row.columns() to
> Collection<ColumnDefinition>
> ----------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-10193
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10193
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: Benedict
> Fix For: 3.0.0 rc1
>
>
> There's not really a lot of reason to store a Columns instance in each row.
> Retaining it introduces extra costs on every row merge, in both consumed CPU
> time and heap.
> While working on CASSANDRA-10045 it became apparent this would be very easy
> to remove, however to avoid scope creep I have filed this as a follow up
> ticket.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
