[
https://issues.apache.org/jira/browse/CASSANDRA-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736218#comment-14736218
]
Jeff Jirsa commented on CASSANDRA-10276:
----------------------------------------
One super trivial nit, not sure if it's even worth correcting:
https://github.com/krummas/cassandra/commit/8d710134854a4c1289be615acb4db35b5e58af3c#diff-2a7b54c2efb47e465bf1e5f09ce7a8f1R371
- {{trimToThreshold}} no longer cares if the incoming sstables are ordered.
They will be, because they'll be sorted in {{getBuckets}} in order to create
the buckets, but {{trimToThreshold}} no longer users nor cares about the
sorting and STCS will just sort by size regardless of the timestamp ordering.
Looks good to me. Not sure my opinion sufficient, but if so, +1 from me.
> With DTCS, do STCS in windows if more than max_threshold sstables
> -----------------------------------------------------------------
>
> Key: CASSANDRA-10276
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10276
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Fix For: 3.x, 2.1.x, 2.2.x
>
>
> To avoid constant recompaction of files in big ( > max threshold) DTCS
> windows, we should do STCS of those files.
> Patch here: https://github.com/krummas/cassandra/commits/marcuse/dtcs_stcs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
