[ 
https://issues.apache.org/jira/browse/CASSANDRA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737172#comment-14737172
 ] 

Philip Thompson edited comment on CASSANDRA-10066 at 9/9/15 4:48 PM:
---------------------------------------------------------------------

Okay, so my local version of pep8 was out of date. The only potentially valid 
change in the remaining output is E731 on line 1841. Do we want to change that 
lambda to a function? It doesn't buy us much, honestly. But to ignore it in CI 
currently would ignore future E731 complaints, which may be more serious.


was (Author: philipthompson):
Okay, so my local version of pep8 was out of date. The only potentially valid 
change in the remaining output is E731 on line 1841. Do we want to change that 
lambda to a function? It doesn't buy us much, honestly. But to ignore it in CI 
currently would ignore future E731 complaints, which may be more valid.

> Bring cqlsh into PEP8 compliance
> --------------------------------
>
>                 Key: CASSANDRA-10066
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10066
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Philip Thompson
>            Assignee: Philip Thompson
>            Priority: Minor
>              Labels: cqlsh
>             Fix For: 3.x, 2.1.x, 2.2.x
>
>
> In order for us to begin running flake8 against cqlsh.py in CI, it would be 
> helpful if it were already PEP8 complaint, with the exception of using 120 
> character lines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to