[
https://issues.apache.org/jira/browse/CASSANDRA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737897#comment-14737897
]
Stefania commented on CASSANDRA-10066:
--------------------------------------
Well I've just read the [pep 8
recommendations|http://legacy.python.org/dev/peps/pep-0008/#programming-recommendations]
(5th bullet point) and the justification they give is that is it better for
tracebacks and string representations to have a function name. It's up to you
really, you can ignore this line with a {{# noqa}} like Tyler suggested in IRC,
or change it to a def function, or even loop on the row values and call
{{writer.writerow}} and {{format_value}} for each value directly.
One more question, what about _pylib/cqlshlib_, does this also need to go into
PEP8 compliance?
> Bring cqlsh into PEP8 compliance
> --------------------------------
>
> Key: CASSANDRA-10066
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10066
> Project: Cassandra
> Issue Type: Bug
> Reporter: Philip Thompson
> Assignee: Philip Thompson
> Priority: Minor
> Labels: cqlsh
> Fix For: 3.x, 2.1.x, 2.2.x
>
>
> In order for us to begin running flake8 against cqlsh.py in CI, it would be
> helpful if it were already PEP8 complaint, with the exception of using 120
> character lines.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
