[
https://issues.apache.org/jira/browse/CASSANDRA-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14847327#comment-14847327
]
Sam Tunnicliffe commented on CASSANDRA-9839:
--------------------------------------------
As it stands, the inheritence hierarchy is not quite as you described it in the
above comment. Where you say {quote}in live clusters, during {{SStableReader}}
initialization it calls
{{ICheckSummedFile.setCrcCheckChanceSupplier(ColumnfamilyStore::getCrcCheckChance)}}
to expose the real time value of {{crc_check_chance}} in a transparent
way{quote}
What's actually the case is that the call in {{SSTR::setupOnline}} is dealing
with concrete instances of {{SegmentedFile}}, not {{IChecksummedFiled}}. The
long and short of it is that {{IChecksummedFiled::setCrcCheckChanceSupplier}}
is currently unused. Making {{SegementedFile}} implement {{IChecksummedFiled}}
of course remedies that.
On that note, I assumed that {{IChecksummedFiled}} was just a typo and it
should actually just be named {{IChecksummedFile}}.
Not a major thing but when smoke testing with cqlsh, I noticed that the warning
when setting the deprecated compression option is displayed twice, do you know
if that's a cqlsh-ism or is the client warning actually being sent twice?
> Move crc_check_chance out of compressions options
> -------------------------------------------------
>
> Key: CASSANDRA-9839
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9839
> Project: Cassandra
> Issue Type: Bug
> Reporter: Aleksey Yeschenko
> Assignee: Paulo Motta
> Priority: Minor
> Labels: client-impacting, docs-impacting
> Fix For: 3.0.0 rc1
>
>
> Follow up to CASSANDRA-8384. The option doesn't belong to compression params
> - it doesn't affect compression, itself, and isn't passed to compressors upon
> initialization.
> While it's true that it is (currently) only being honored when reading
> compressed sstables, it still doesn't belong to compression params (and is
> causing CASSANDRA-7978 -like issues).
> [~tjake] suggested we should make it an option of its own, and I think we
> should.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
