[
https://issues.apache.org/jira/browse/CASSANDRA-7392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877285#comment-14877285
]
Stefania commented on CASSANDRA-7392:
-------------------------------------
bq. This comment seems out of place?
Removed, thank you.
bq. What is this change to Slices, is it fixing an NPE? I am guessing you found
a few things making heavier use of toCQLString.
It fixes a small bug in creating the CQL string, without this change we end up
with an unnecessary "AND () = ()"
bq. This is random now so the comment is out of date
Comment updated thanks.
bq. If only a fixed number of timed out queries are reported how about only
storing references to the first N? Allocating an ArrayList per query doesn't
make much sense if aggregating doesn't really work yet although it's necessary
to count identical queries.
bq. [Check if debug is enabled before formatting the string and
logging?|https://github.com/apache/cassandra/compare/trunk...stef1927:7392-3.0#diff-e06002c30313f8ead63ee472617d1b10R147
Both done, thank you.
bq. This is set to 30
Not sure I understand, perhaps the link is wrong?
bq. I think the utests would be closer to trunk if you rebased. The dtests will
get a lot worse though.
So far I've kept the 7392-3.0 branch up-to-date with cassandra-3.0 since I
assumed it would be committed on this branch. I've also resurrected the old
7392 branch however, which is now identical to 7392-3.0 but rebased on trunk,
so we have CI for both. There was only one small conflict in
{{DatabaseDescriptor}}.
CI links:
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-7392-3.0-dtest/
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-7392-3.0-testall/
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-7392-dtest/
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-7392-testall/
> Abort in-progress queries that time out
> ---------------------------------------
>
> Key: CASSANDRA-7392
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7392
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stefania
> Priority: Critical
> Fix For: 3.x
>
>
> Currently we drop queries that time out before we get to them (because node
> is overloaded) but not queries that time out while being processed.
> (Particularly common for index queries on data that shouldn't be indexed.)
> Adding the latter and logging when we have to interrupt one gets us a poor
> man's "slow query log" for free.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
