[
https://issues.apache.org/jira/browse/CASSANDRA-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kelvin Kakugawa updated CASSANDRA-1937:
---------------------------------------
Attachment: CASSANDRA-1937-ALT-0001.patch
The logic refactor looks good.
Fixed an edge case in the attached patch. In merge(), we don't check whether
the right offset exceeds the right length.
> Keep partitioned counters ("contexts") sorted
> ---------------------------------------------
>
> Key: CASSANDRA-1937
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1937
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Fix For: 0.8
>
> Attachments: 0001-Keep-counter-partitioned-context-sorted.patch,
> CASSANDRA-1937-ALT-0001.patch
>
> Original Estimate: 4h
> Time Spent: 4h
> Remaining Estimate: 0h
>
> In the value of CounterColumns, the code keep the subpart unsorted, but sort
> them 'on the fly' when needed (in diff() and merge()). It will be more
> efficient to keep the parts always sorted (it will also be easier in that it
> will remove the need of the ad-hoc in-place quicksort in CounterContext).
> NOTE: this breaks the on-disk file format (for counters)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
