[
https://issues.apache.org/jira/browse/CASSANDRA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14937943#comment-14937943
]
Joshua McKenzie commented on CASSANDRA-7918:
--------------------------------------------
Squashed your commits and touched up some style nits while reviewing - pushed
[here|https://github.com/apache/cassandra/commit/2da39df3543ac6f27502d8498f4ea783127d8c8d]
Patch looks solid. I didn't go in-depth reviewing the .html file included, but
as for the java side I have a couple of outstanding questions:
* MultiPrintStream has quite a few non-overridden base (write*/print*) methods
that would allow writing to the base stream without writing to the additional
streams. I'd recommend we override all print/write methods to make them
multiStream compatible.
* In StressAction, the following looks incorrect to me:
{code:title=mismatch}
if (settings.rate.minThreads > 0)
{
output.println("Thread count was not specified, testing multiple thread
counts");
{code}
settings.rate.minThreads looks to indicate our preferred min thread-count which
that output message contradicts.
Just about good to commit once we get those two minor things ironed out. Thanks
for sticking with this!
> Provide graphing tool along with cassandra-stress
> -------------------------------------------------
>
> Key: CASSANDRA-7918
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7918
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Benedict
> Assignee: Ryan McGuire
> Priority: Minor
> Attachments: 7918.txt, reads.svg
>
>
> Whilst cstar makes some pretty graphs, they're a little limited and also
> require you to run your tests through it. It would be useful to be able to
> graph results from any stress run easily.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
