[
https://issues.apache.org/jira/browse/CASSANDRA-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938771#comment-14938771
]
Carl Yeksigian commented on CASSANDRA-10323:
--------------------------------------------
Overall +1. I pushed [a
branch|https://github.com/carlyeks/cassandra/tree/review/10323/3.0] with just a
few nits; if you could take a look at them [~cnlwsu].
* Removed the overload of {{mutateMV}} since we haven't hit a stable release
with MV in yet.
* Don't initialize the {{viewLockAcquire}} and {{viewRead}} metrics if this is
a view. I was expecting those values to be updated when I was looking at the
metrics; probably makes sense to just not have them at all for views instead of
having the unused metrics.
* Formatting miscellany
> Add more MaterializedView metrics
> ---------------------------------
>
> Key: CASSANDRA-10323
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10323
> Project: Cassandra
> Issue Type: Improvement
> Reporter: T Jake Luciani
> Assignee: Chris Lohfink
> Fix For: 3.0.0 rc2
>
> Attachments: trunk-10323-v2.txt, trunk-10323.txt
>
>
> We need to add more metrics to help understand where time is spent in
> materialized view writes. We currently track the ratio of async base -> view
> mutations that fail.
> We should also add
> * The amount of time spent waiting for the partition lock (contention)
> * The amount of time spent reading data
> Any others?
> [~carlyeks] [~jkni]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
