[
https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948701#comment-14948701
]
Robert Stupp commented on CASSANDRA-10383:
------------------------------------------
Looked a bit deeper into the code and did a quick, successful test. Nice work +
the code itself looks really good!
* {{test_cqlsh_completion.py}} misses the new keyword (look out for
{{bloom_filter_fp_chance}} as a reference).
* I’d prefer to have a unit test for this change. You can add a separate unit
test class or extend {{SchemaKeyspaceTest}}. Issuing the operations that
trigger an auto-snapshot and use
{{Keyspace.getColumnFamilyStore}}+{{ColumnFamilyStore.getSnapshot*}} methods to
verify whether it works (in both cases).
* Thift API CF modification: I can think of a situation when updating the table
via thrift may reset the value (or not set the default value). Not sure whether
there should be some change in
{{ThriftConversion.internalFromThrift/fromThriftForUpdate/fromThrift}}.
[~iamaleksey] or someone else?
* Personally I’d like to move the several
{{cfs.metadata.params.allowAutoSnapshot &&
DatabaseDescriptor.isAutoSnapshot()}} tests into a new instance method in CFS.
Would also make unit testing easier.
* I'd favour adding this as a new feature for 3.0. Maybe even a bit too late
for new features for 3.0. But unsure whether to add this to 2.1/2.2 line.
> Disable auto snapshot on selected tables.
> -----------------------------------------
>
> Key: CASSANDRA-10383
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10383
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Tommy Stendahl
> Assignee: Tommy Stendahl
> Fix For: 2.1.x
>
> Attachments: 10383.txt
>
>
> I have a use case where I would like to turn off auto snapshot for selected
> tables, I don't want to turn it off completely since its a good feature.
> Looking at the code I think it would be relatively easy to fix.
> My plan is to create a new table property named something like
> "disable_auto_snapshot". If set to false it will prevent auto snapshot on the
> table, if set to true auto snapshot will be controlled by the "auto_snapshot"
> property in the cassandra.yaml. Default would be true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
