[
https://issues.apache.org/jira/browse/CASSANDRA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954737#comment-14954737
]
Stefania commented on CASSANDRA-10421:
--------------------------------------
[~aweisberg] I have something that passes unit tests but I still have to clean
it up a bit. Specifically, I need to improve error messages, test coverage, do
a self code review and I will probably also split the {{LogFile}} class in two:
one for wrapping the replicas on disk and one for the actual txn operations.
I am not sure if you prefer to take a look at the WIP code given the tight
deadline or to wait until it is complete.
I've also renamed the branch to avoid windows dtest running every time, see
[here|https://github.com/stef1927/cassandra/commits/10421-3.0]. I will only
push to the windows branch at the very end to run dtests once.
New CI links:
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10421-3.0-dtest
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10421-3.0-testall
> Potential issue with LogTransaction as it only checks in a single directory
> for files
> -------------------------------------------------------------------------------------
>
> Key: CASSANDRA-10421
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10421
> Project: Cassandra
> Issue Type: Bug
> Reporter: Marcus Eriksson
> Assignee: Stefania
> Priority: Blocker
> Fix For: 3.0.0 rc2
>
>
> When creating a new LogTransaction we try to create the new logfile in the
> same directory as the one we are writing to, but as we use
> {{[directories.getDirectoryForNewSSTables()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java#L125]}}
> this might end up in "any" of the configured data directories. If it does,
> we will not be able to clean up leftovers as we check for files in the same
> directory as the logfile was created:
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogRecord.java#L163
> cc [~Stefania]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
