[ 
https://issues.apache.org/jira/browse/CASSANDRA-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14961024#comment-14961024
 ] 

Sam Tunnicliffe commented on CASSANDRA-10543:
---------------------------------------------

It seems like the most straightforward way to resolve this is to partially 
revert CASSANDRA-9839. In the branch linked below, I've removed 
{{IChecksummedFile}} and gone back to {{CompressedRandomAccessReader}} getting 
the crc check chance from {{CompressionMetadata.parameters}}. Checksums were 
not being made/checked for non-compressed files anyway, so we can figure out a 
better approach when we add that.

||3.0||
|[branch|https://github.com/beobal/cassandra/tree/10543-3.0]|
|[testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10543-3.0-testall/]|
|[dtests|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10543-3.0-dtest/]|

> Self-reference leak in SegmentedFile
> ------------------------------------
>
>                 Key: CASSANDRA-10543
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10543
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>            Priority: Critical
>             Fix For: 3.0.0 rc2
>
>
> CASSANDRA-9839, which moved {{crc_check_chance}} out of compression params 
> and made it a top level table property introduced a reference leak in 
> {{SegmentedFile}}. See [this 
> comment|https://issues.apache.org/jira/browse/CASSANDRA-9839?focusedCommentId=14960528&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14960528
>  ] from [~benedict]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to