[
https://issues.apache.org/jira/browse/CASSANDRA-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966792#comment-14966792
]
Jeremiah Jordan commented on CASSANDRA-10415:
---------------------------------------------
Well. Up until this change it works under 2.6. Can we not make the simple one
character fix to continue doing do in Cassandra 2.1? Changing that this late
in 2.1 seems wrong to me.
> Fix cqlsh bugs
> --------------
>
> Key: CASSANDRA-10415
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10415
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Jim Witschey
> Assignee: Stefania
> Labels: cqlsh
> Fix For: 3.0.0 rc2, 2.2.4, 2.1.12
>
>
> This is followup to CASSANDRA-10289
> The tests currently failing should be:
> *
> {{cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion.test_complete_in_create_columnfamily}}
> ** uses {{create_columnfamily_table_template}}. Stefania says "the {{(}}
> after {{CREATE ... IF}} does not look valid to me."
> *
> {{cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion.test_complete_in_create_table}}
> ** uses {{create_columnfamily_table_template}}, see above.
> *
> {{cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion.test_complete_in_delete}}
> ** Stefania says: "I don't think keyspaces are a valid completion after
> {{DELETE a [}} and after {{DELETE FROM twenty_rows_composite_table USING
> TIMESTAMP 0 WHERE TOKEN(a) >=}}. From a quick analysis of {{cqlhandling.py}}
> I think it comes from {{<term>}}, which picks up {{<functionName>}}, which
> was changed to include {{ks.}} by CASSANDRA-7556.
> *
> {{cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion.test_complete_in_drop_keyspace}}
> ** Stefania says: "the {{;}} after {{DROP KEYSPACE IF}} is not valid.
> * {{cqlshlib.test.test_cqlsh_output.TestCqlshOutput.test_timestamp_output}}
> ** already documented with CASSANDRA-10313 and CASSANDRA-10397
> I'm happy to break these out into separate tickets if necessary.
> To run the tests locally, I cd to {{cassandra/pylib/cqlshlib}} and run the
> following:
> {code}
> ccm create -n 1 --install-dir=../.. test
> ccm start --wait-for-binary-proto
> nosetests test 2>&1
> ccm remove
> {code}
> This requires nose and ccm. Until CASSANDRA-10289 is resolved, you'll have to
> use my branch here: https://github.com/mambocab/cassandra/tree/fix-cqlsh-tests
> Tests for this branch are run (non-continuously) here:
> http://cassci.datastax.com/job/scratch_mambocab-fix_cqlsh/
> Assigning [~Stefania] for now, since she's already looked at 10289, but feel
> free to reassign.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
