[ 
https://issues.apache.org/jira/browse/CASSANDRA-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977509#comment-14977509
 ] 

Jeff Jirsa commented on CASSANDRA-10276:
----------------------------------------

I haven't convinced myself of the 'best' way to handle the case where you have 
more than min_threshold files, but no stcs compaction candidates - in TWCS, I 
compact them in older windows, justifying that decision with the rationale that 
it should be fairly rare, though I think it's also reasonable to say that a few 
sstables per window is fine, and it's better to save the write amplification. 
Given that I can make arguments on either side, I'm fine with your choice. 

[~krummas] - latest patch looks reasonable to me. +1



> With DTCS, do STCS in windows if more than max_threshold sstables
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-10276
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10276
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 3.x, 2.1.x, 2.2.x
>
>
> To avoid constant recompaction of files in big ( > max threshold) DTCS 
> windows, we should do STCS of those files.
> Patch here: https://github.com/krummas/cassandra/commits/marcuse/dtcs_stcs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to