[
https://issues.apache.org/jira/browse/CASSANDRA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978164#comment-14978164
]
Sylvain Lebresne commented on CASSANDRA-10606:
----------------------------------------------
The patch looks good.
For the unit tests, maybe I'm nitpicking but I would prefer avoiding
{{SchemaLoader}} for new tests if possible (it's ugly and overly complex most
of the time). We can use {{CQLTester}} instead: creating tables is a lot more
natural and you can use the existing {{currentTableMetadata()}} to get the
{{CFMetadata}} for the current table (which is all those tests care about). The
rest of the tests (building the update and asserting) can stay unchanged.
> PartitionUpdate.operationCount() return the wrong number of operation for
> compact tables
> ----------------------------------------------------------------------------------------
>
> Key: CASSANDRA-10606
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10606
> Project: Cassandra
> Issue Type: Bug
> Reporter: Benjamin Lerer
> Assignee: Benjamin Lerer
> Fix For: 3.0.0
>
> Attachments: 10606-3.0-V2.txt, 10606-3.0.txt
>
>
> For compact tables {{PartitionUpdate.operationCount()}} return the wrong
> number of operation as it does not take into operation on static rows.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
