[ 
https://issues.apache.org/jira/browse/CASSANDRA-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981978#action_12981978
 ] 

Jon Hermes commented on CASSANDRA-1906:
---------------------------------------

- Dropping avro (CASSANDRA-926) makes the [KS,CF,Column]Def changes much 
easier. I know at least CfDef will be cut in half.
- If not dropping YAML entirely, then at least cleaning up the code around it 
and making a serious effort to use YAMLBeans (previous reverted yaml lib 
changes (CASSANDRA-1313) removed >100 lines of code, and YAMLBeans itself is 
~10% the mass of snakeYAML) should be done. The differences between the 
libraries are now known.
- Taking a census of all the settings knobs and sorting them into JMX vs. 
Thrift needs to be done to make the separation consistent, or if this isn't 
done, then we should have all methods available on both Thrift and JMX. In 
either case, the reasoning is that future methods won't have to endure an 
argument as to their placement; i.e. either it obviously goes in one, or 
necessarily goes in both.

The core tenet of this improvement/ticket is making the code easier for future 
maintenance; the more unnecessary lines removed and the more commentary and 
documentation available the better. There's currently a *ton* of redundant code 
and deprecated flags running around in DD, the Defs, and SS, and missing a 
single spot of redundancy means an unusable feature (CASSANDRA-1606, 
CASSANDRA-1466).

> Sanitize configuration code
> ---------------------------
>
>                 Key: CASSANDRA-1906
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1906
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jon Hermes
>            Assignee: Jon Hermes
>            Priority: Minor
>             Fix For: 0.8
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Multipart:
> - Drop deprecated YAML config. Only config allowed is via thrift/JMX. Make 
> this gratuitously easy to do with sane defaults and accepting changesets as 
> opposed to full definitions.
> - Combine common code between KS/CF/ColumnDefs and between thrift/avro defs.
> - Provide an obvious and clean interface for changing settings locally versus 
> globally (JMX vs. thrift). Dox here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to