[ https://issues.apache.org/jira/browse/CASSANDRA-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992368#comment-14992368 ]
Carl Yeksigian commented on CASSANDRA-10634: -------------------------------------------- Proposed changes look good -- can we change the names of the variables to just "baseEndpoints" and "viewEndpoints". Also, can you add a sentence about DC-locality to the comment at the top of the method; it's unclear that it is doing anything special with DC's from the comment. > Materialized Views filter paired endpoints to local DC even when not using > DC-aware replication > ----------------------------------------------------------------------------------------------- > > Key: CASSANDRA-10634 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10634 > Project: Cassandra > Issue Type: Bug > Components: Coordination > Reporter: Joel Knighton > Assignee: Joel Knighton > Fix For: 3.0.0 > > > When calculating paired view replicas on MV writes, we filter out base and > view replicas that aren't in the local datacenter. > If we are using SimpleStrategy, this filtering is incorrect, since our > replica placement is not datacenter aware. > We should behave the same as DC-aware consistency levels and only perform > this datacenter-aware filtering if the replication strategy is an instance of > NetworkTopologyStrategy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)