[ 
https://issues.apache.org/jira/browse/CASSANDRA-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010925#comment-15010925
 ] 

Sam Tunnicliffe commented on CASSANDRA-10678:
---------------------------------------------

I guess the following is a prerequisite of 
https://github.com/xedin/sasi/issues/3, but I'll mention it here anyway:

{{SSTableFlushObserver::startRow}} is misnamed, being called when before a 
partition, not a row, is written to the SSTable. In fact, rows are not really 
tracked at all during the flush, only partitions and cells. The corresponding 
tests also highlight this. So at least one additional method is required on the 
interface to capture events at this level. Is it possible that RTs may be of 
interest to some observers too? If so, perhaps we also need another method for 
those. 

Nit: missing javadoc for {{Index::getFlushObserver}}

The {{SSTableFlushObserver.Source}} enum is unused at the moment. Is this in 
preparation for an upcoming patch, or a leftover from the pre-3.0 version?


> add SSTable flush observer
> --------------------------
>
>                 Key: CASSANDRA-10678
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10678
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Pavel Yaskevich
>            Assignee: Pavel Yaskevich
>             Fix For: 3.x
>
>
> Add general interface which can intercept per SSTable flush events e.g. - 
> start of the key, columns etc. Make Index interface return such observer on 
> request, which couples index with corresponding SSTable file if needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to