[
https://issues.apache.org/jira/browse/CASSANDRA-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012019#comment-15012019
]
Jim Witschey commented on CASSANDRA-10541:
------------------------------------------
Review:
* [This
logic|https://github.com/apache/cassandra/compare/cassandra-2.2...pauloricardomg:2.2-10541#diff-d282de1646d1226964b9253414b38069R531]
would be easier to read as
{code}
if c.realtty:
...
i = 1
else:
i = 0
{code}
also, {{i}} should have a more descriptive name.
* spelling errors in the comments [here (pottentially ->
potentially)|https://github.com/apache/cassandra/compare/cassandra-2.2...pauloricardomg:2.2-10541#diff-43a61e69174a5b963a3b61acaf2c1d5fR29]
and [here (assynchronously ->
assynchronously)|https://github.com/apache/cassandra/compare/cassandra-2.2...pauloricardomg:2.2-10541#diff-43a61e69174a5b963a3b61acaf2c1d5fR38]
* Was [this
assertion|https://github.com/apache/cassandra/compare/cassandra-2.2...pauloricardomg:2.2-10541#diff-d282de1646d1226964b9253414b38069L372]
deleted intentionally?
* Could you run the WinPty file through PEP8? There are definitely some style
errors in there; I'm not sure why the dtest that PEP8s the cqlshlib module
passes. [~philipthompson] any thoughts on that one?
Other than those comments, these look good! That WinPty implementation is
impressive. I'll set up CassCI jobs for the other branches as well and post
links here.
> cqlshlib tests cannot run on Windows
> ------------------------------------
>
> Key: CASSANDRA-10541
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10541
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Reporter: Benjamin Lerer
> Assignee: Paulo Motta
> Priority: Minor
> Labels: cqlsh, windows
> Fix For: 2.2.x, 3.0.x, 3.x
>
>
> If I try to run the {{cqlshlib}} tests on Windows, I got the following error:
> {quote}
> ======================================================================
> ERROR: Failure: AttributeError ('module' object has no attribute 'symlink')
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "C:\Python27\lib\site-packages\nose\loader.py", line 414, in
> loadTestsFromName
> addr.filename, addr.module)
> File "C:\Python27\lib\site-packages\nose\importer.py", line 47, in
> importFromPath
> return self.importFromDir(dir_path, fqname)
> File "C:\Python27\lib\site-packages\nose\importer.py", line 94, in
> importFromDir
> mod = load_module(part_fqname, fh, filename, desc)
> File "[...]\pylib\cqlshlib\test\__init__.py", line 17, in <module>
> from .cassconnect import create_test_db, remove_test_db
> File "[...]\pylib\cqlshlib\test\cassconnect.py", line 22, in <module>
> from .basecase import cql, cqlsh, cqlshlog, TEST_HOST, TEST_PORT, rundir
> File "[...]\pylib\cqlshlib\test\basecase.py", line 43, in <module>
> os.symlink(path_to_cqlsh, modulepath)
> AttributeError: 'module' object has no attribute 'symlink'
> ----------------------------------------------------------------------
> Ran 1 test in 0.002s
> FAILED (errors=1)
> {quote}
> The problem comes from the fact tha Windows has no support for symlinks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
