[ 
https://issues.apache.org/jira/browse/CASSANDRA-10280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015457#comment-15015457
 ] 

Branimir Lambov commented on CASSANDRA-10280:
---------------------------------------------

Patch LGTM.

Nit: [The no-arguments 
constructor|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/10280-trunk#diff-687b688750330c623a9a3df3f7a59e78R67]
 still specifies 1 day directly; it should use the 
{{DEFAULT_MAX_WINDOW_SIZE_SECONDS}} constant.

> Make DTCS work well with old data
> ---------------------------------
>
>                 Key: CASSANDRA-10280
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10280
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 2.1.x, 2.2.x, 3.x
>
>
> Operational tasks become incredibly expensive if you keep around a long 
> timespan of data with DTCS - with default settings and 1 year of data, the 
> oldest window covers about 180 days. Bootstrapping a node with vnodes with 
> this data layout will force cassandra to compact very many sstables in this 
> window.
> We should probably put a cap on how big the biggest windows can get. We could 
> probably default this to something sane based on max_sstable_age (ie, say we 
> can reasonably handle 1000 sstables per node, then we can calculate how big 
> the windows should be to allow that)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to