[
https://issues.apache.org/jira/browse/CASSANDRA-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023553#comment-15023553
]
Stefania commented on CASSANDRA-10243:
--------------------------------------
Thanks for your review. Here is the next update:
bq. It's not very common to update snitch property of a live node (specially
with GPFS), so I don't think the warning is necessary. Should we maybe add a
note to NEWS.txt instead? Or maybe print the warn on 2.1/2.2, and remove it on
3.0?
Added a note to NEWS.txt and removed the warning.
bq. On CASSANDRA-9474 we changed the property name from override_rackdc to the
original ignore_rack in addition to ignore_dc, could you please fix dtests?
I've updated the tests and removed the @require on 9474 (I've added ignore_rack
to 2.2 so we can run the full tests on Jenkins via DTEST_REPO and DTEST_BRANCH).
bq. Instead of manipulating gossip EndpointState in
StorageProxy.truncateBlocking(), what do you think about adding a
excludeNodesInDeadState option to StorageService.getLiveMembers and
Gossiper.getLiveMembers (which you could also rename it to
Gossiper.getLiveEndpoints)?
Done
bq. Please fix nodetool_test.TestNodetool.test_correct_dc_rack_in_nodetool_info
dtest
Now that the GPFS error is gone this test is fine, thanks for checking this.
bq. It seems 3.1 dtest did not run, mind resubmitting please?
Submitted together with the other branches just now. The reason I did not
submit it yesterday is because the 3.1 branch is identical to the 3.0 branch
(checked with git diff).
I'll post another update once CI completes.
> Warn or fail when changing cluster topology live
> ------------------------------------------------
>
> Key: CASSANDRA-10243
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10243
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Stefania
> Priority: Critical
> Fix For: 2.1.x
>
>
> Moving a node from one rack to another in the snitch, while it is alive, is
> almost always the wrong thing to do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
