[ 
https://issues.apache.org/jira/browse/CASSANDRA-10761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036244#comment-15036244
 ] 

Sam Tunnicliffe commented on CASSANDRA-10761:
---------------------------------------------

Those suggestions seem sensible, one query though re: 

bq.I don't think Schema.load should be called first

As far as I can tell, the cfIdMap is only ever used for lookups, never iterated 
over, i.e. you have to already know about a CF's existence before you'd use the 
map. Wouldn't it be safer in that case to add the new table to the map before 
it becomes discoverable via KeyspaceMetadata.Tables? NBD really as I don't see 
any scenario which would cause a lookup given that any caller with the KSM can 
just get the full CFMetaData directly from it, it just that populating the map 
before publishing the KSM doesn't seem so crazy.

Regardless, +1 on the other points, the CI is running now.


> Possible regression of CASSANDRA-9201
> -------------------------------------
>
>                 Key: CASSANDRA-10761
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10761
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Philip Thompson
>            Assignee: Sam Tunnicliffe
>             Fix For: 3.0.1, 3.1, 2.2.x
>
>         Attachments: 10761-logs.tar.gz
>
>
> Some dtests like 
> {{consistency_test.TestAccuracy.test_network_topology_strategy_each_quorum_counters}}
>  are failing with the follow auth related assertion exception
> {code}
> [node6 ERROR] java.lang.AssertionError: 
> org.apache.cassandra.exceptions.InvalidRequestException: unconfigured table 
> roles
>       at 
> org.apache.cassandra.auth.CassandraRoleManager.prepare(CassandraRoleManager.java:450)
>       at 
> org.apache.cassandra.auth.CassandraRoleManager.setup(CassandraRoleManager.java:144)
>       at 
> org.apache.cassandra.service.StorageService.doAuthSetup(StorageService.java:1036)
>       at 
> org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:984)
>       at 
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:708)
>       at 
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:579)
>       at 
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:345)
>       at 
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:561)
>       at 
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:689)
> Caused by: org.apache.cassandra.exceptions.InvalidRequestException: 
> unconfigured table roles
>       at 
> org.apache.cassandra.thrift.ThriftValidation.validateColumnFamily(ThriftValidation.java:114)
>       at 
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:757)
>       at 
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:752)
>       at 
> org.apache.cassandra.auth.CassandraRoleManager.prepare(CassandraRoleManager.java:446)
>       ... 8 more
> {code}
> This looks very similar to CASSANDRA-9201.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to