[ 
https://issues.apache.org/jira/browse/CASSANDRA-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042065#comment-15042065
 ] 

Ariel Weisberg commented on CASSANDRA-10816:
--------------------------------------------

+1 I think this is fine for 2.2+. I wouldn't object much to it going in 2.1 
since it is pretty minor and the additional exception handling is so similar to 
what is already there.

> Explicitly handle SSL handshake errors during connect()
> -------------------------------------------------------
>
>                 Key: CASSANDRA-10816
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10816
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Streaming and Messaging
>            Reporter: Stefan Podkowinski
>            Assignee: Stefan Podkowinski
>             Fix For: 2.1.x, 2.2.x
>
>
> Diagnosing internode SSL issues can be a problem as any messaging 
> {{IOException}} before this patch is just logged to debug, which is likely 
> not enabled in most cases. Logs will just show nothing in case of any 
> problems with SSL certs. 
> Also the implemented retry semantics in {{OutboundTcpConnection}} will not 
> make much sense for SSL handshake errors and will cause unnecessary load for 
> both peers.
> The proposed patch will explicitly catch {{SSLHandshakeException}}, log them 
> to error and abort connect().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to