[
https://issues.apache.org/jira/browse/CASSANDRA-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049440#comment-15049440
]
Paulo Motta commented on CASSANDRA-10580:
-----------------------------------------
[~anubhavk] you provided the patch against the
[trunk/3.2|https://github.com/apache/cassandra/tree/trunk] branch, not
[cassandra-2.1|https://github.com/apache/cassandra/tree/cassandra-2.1].
Below are some comments:
* On {{LocalMutationRunnable}}:
** replace {{warn}} log with {{debug}}
** You cannot have an empty constructor, otherwise the logging will fail with
{{NullPointerException}}
* On {{MessageDeliveryTask}}:
** In order not to expose mutation details in the logs, you should either not
print the received message (which can be a mutation) or somehow extract the
ks/cf information from the message and print that.
* Replace tabs with spaces and remove lines with blank spaces
**
{noformat}/home/paulo/Workspace/cassandra/cassandra/.git/rebase-apply/patch:15:
space before tab in indent.
long timeTaken = System.currentTimeMillis() -
message.constructionTime.timestamp;
/home/paulo/Workspace/cassandra/cassandra/.git/rebase-apply/patch:16: space
before tab in indent.
logger.debug("MessageDeliveryTask ran after {} ms, allowed time
was {} ms. Dropping message {}", timeTaken, message.getTimeout(),
message.toString());
/home/paulo/Workspace/cassandra/cassandra/.git/rebase-apply/patch:17: space
before tab in indent.
MessagingService.instance().incrementDroppedMessages(message);
/home/paulo/Workspace/cassandra/cassandra/.git/rebase-apply/patch:38: trailing
whitespace.
/home/paulo/Workspace/cassandra/cassandra/.git/rebase-apply/patch:41: trailing
whitespace.
warning: squelched 11 whitespace errors
warning: 16 lines add whitespace errors.
{noformat}
We're starting to freeze improvements to 2.1 and since this is on the critical
path could you provide patches for 2.2, 3.0 and trunk? They will probably
diverge since things have changed between different versions. The strategy I
use is to start from lowest version branch and fix conflicts while
cherry-picking commit to upper branches.
Will cancel the patch on JIRA while comments are being addressed, please
resubmit patch once ready.
Thanks!
> On dropped mutations, more details should be logged.
> ----------------------------------------------------
>
> Key: CASSANDRA-10580
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10580
> Project: Cassandra
> Issue Type: Improvement
> Components: Coordination
> Environment: Production
> Reporter: Anubhav Kale
> Assignee: Anubhav Kale
> Priority: Minor
> Fix For: 2.1.x
>
> Attachments: 10580.patch, CASSANDRA-10580-Head.patch
>
>
> In our production cluster, we are seeing a large number of dropped mutations.
> At a minimum, we should print the time the thread took to get scheduled
> thereby dropping the mutation (We should also print the Message / Mutation so
> it helps in figuring out which column family was affected). This will help
> find the right tuning parameter for write_timeout_in_ms.
> The change is small and is in StorageProxy.java and MessagingTask.java. I
> will submit a patch shortly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
