[
https://issues.apache.org/jira/browse/CASSANDRA-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058265#comment-15058265
]
Robert Stupp commented on CASSANDRA-10750:
------------------------------------------
Your changes LGTM and I've cherry-picked them onto my branch.
Also removed the tail-recursion changes in stress - I'd like to leave the other
changes as these are in "hot" code paths.
Triggered another CI run. Not sure whether we can get a clean run (without
timeouts). It not, I can run these tests locally.
> Minor code improvements
> -----------------------
>
> Key: CASSANDRA-10750
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10750
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Robert Stupp
> Assignee: Robert Stupp
> Priority: Minor
>
> Went though several IDE inspections and found some places in the code that
> could be improved. These are just minor improvements and no bug fixes (except
> one minor "theoretical" thing).
> The [branch on github against
> trunk|https://github.com/snazy/cassandra/tree/10750-code-opts-trunk] contains
> a series of commits:
> * simplify Mutation.apply to remove the casts
> * "minor code improvements" just replaces some expressions that are
> effectively constant
> * remove unused assignments (probably just cosmetic)
> * collapse identical if-branches (probably just cosmetic)
> * empty array constants
> * fix printf usage (could potentially raise an exception in printf)
> * replace tail-recursion in some critical sections (as the JVM cannot
> optimize that AFAIK)
> * remove methods identical to their super methods (probably just cosmetic)
> [cassci results
> here|http://cassci.datastax.com/view/Dev/view/snazy/search/?q=snazy-10750-]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
