[ 
https://issues.apache.org/jira/browse/CASSANDRA-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062087#comment-15062087
 ] 

Paulo Motta commented on CASSANDRA-10859:
-----------------------------------------

Test is fixed, but can't we improve this a bit by creating a constructor that 
receives only the bucket data and creates the bucket offsets internally? So, 
this:
{code:java}
            long[] rowSizeBucketOffsets = new 
EstimatedHistogram(estimatedRowSize.length - 1).getBucketOffsets();
            long[] columnCountBucketOffsets = new 
EstimatedHistogram(estimatedColumnCount.length - 1).getBucketOffsets();
            EstimatedHistogram rowSizeHist = new 
EstimatedHistogram(rowSizeBucketOffsets, estimatedRowSize);
            EstimatedHistogram columnCountHist = new 
EstimatedHistogram(columnCountBucketOffsets, estimatedColumnCount);
{code}
would become:
{code:java}
            EstimatedHistogram rowSizeHist = new 
EstimatedHistogram(estimatedRowSize);
            EstimatedHistogram columnCountHist = new 
EstimatedHistogram(estimatedColumnCount);
{code}


> AssertionError in nodetool cfhistograms
> ---------------------------------------
>
>                 Key: CASSANDRA-10859
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10859
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Tools
>            Reporter: Jim Witschey
>            Assignee: Yuki Morishita
>             Fix For: 3.0.x, 3.x
>
>
> {{nodetool cfhistograms}} raises an {{AssertionError}} on the CassCI 
> {{trunk}} jobs:
> http://cassci.datastax.com/job/trunk_dtest/lastCompletedBuild/testReport/jmx_test/TestJMX/cfhistograms_test/history/
> This regression started in this build on CassCI and has failed consistently 
> since then:
> http://cassci.datastax.com/job/trunk_dtest/806/testReport/junit/jmx_test/TestJMX/cfhistograms_test/
> I can't find any recent dtest changes to this method, so I believe it's a 
> Cassandra bug. Here's the changeset for the first failing build:
> http://cassci.datastax.com/job/trunk_dtest/806/changes
> Maybe something in the changes to the scripts here introduced the bug:
> https://github.com/apache/cassandra/commit/b5240204d7aa2a32c6649d19da2b961c856cde28
> [~jjordan] could you have a look at this please?
> This appears to only affect {{trunk}} at present.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to