[
https://issues.apache.org/jira/browse/CASSANDRA-8755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073932#comment-15073932
]
Alexander Shopov commented on CASSANDRA-8755:
---------------------------------------------
Current state is in pull request https://github.com/apache/cassandra/pull/60
Two commits - first is unit tests to verify initial behavior. Second is the
patch itself - recheck with unit tests.
Command to check created tests:
------
ant testsome -Dtest.name=org.apache.cassandra.config.CFMetaDataTest
-Dtest.methods=testIsNameValidPositive,testIsNameValidNegative
ant testsome -Dtest.name=org.apache.cassandra.config.DatabaseDescriptorTest
-Dtest.methods=testTokensFromString
ant testsome -Dtest.name=org.apache.cassandra.cql3.ColumnIdentifierTest
-Dtest.methods=testMaybeQuote
ant testsome
-Dtest.name=org.apache.cassandra.cql3.statements.PropertyDefinitionsTest
-Dtest.methods=testGetBooleanExistant,testGetBooleanNonexistant
ant testsome
-Dtest.name=org.apache.cassandra.db.marshal.AbstractCompositeTypeTest
-Dtest.methods=testEscape,testUnescape
ant testsome
-Dtest.name=org.apache.cassandra.metrics.CassandraMetricsRegistryTest
-Dtest.methods=testChooseType,testMetricName
ant testsome -Dtest.name=org.apache.cassandra.cql3.ColumnIdentifierTest
-Dtest.methods=testMaybeQuote
ant testsome -Dtest.name=org.apache.cassandra.schema.IndexMetadataTest
-Dtest.methods=testIsNameValidPositive,testIsNameValidNegative,testGetDefaultIndexName
ant testsome -Dtest.name=org.apache.cassandra.utils.CassandraVersionTest
-Dtest.methods=testParseIdentifiersPositive,testParseIdentifiersNegative
------
No unit tests for:
src/java/org/apache/cassandra/db/marshal/TupleType.java
src/java/org/apache/cassandra/index/internal/CassandraIndex.java
src/java/org/apache/cassandra/service/StorageService.java
These seem hard and I have to do quite a bit of mocking an mucking around.
Hints welcome.
No unit tests for:
src/java/org/apache/cassandra/db/commitlog/CommitLogArchiver.java
src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java
Testing changes there will need refactoring these classes. They seem very
central to Cassandra so I am waiting for advice whether and how to proceed.
> Replace trivial uses of String.replace/replaceAll/split with StringUtils
> methods
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-8755
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8755
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jaroslav Kamenik
> Priority: Trivial
> Labels: lhf
> Attachments: 8755.tar.gz, trunk-8755.patch, trunk-8755.txt
>
>
> There are places in the code where those regex based methods are used with
> plain, not regexp, strings, so StringUtils alternatives should be faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
