[
https://issues.apache.org/jira/browse/CASSANDRA-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076136#comment-15076136
]
Tyler Hobbs commented on CASSANDRA-10953:
-----------------------------------------
Overall this looks good, thanks! A few minor review comments:
* Some of the help error messages say "counter write" (with a space), while the
actual type is "counterwrite" (without a space)
* In {{GetTimeout}}, the usage for the {{timeout_type}} arg is a repeat of the
command description. Also, you're missing whitespace around the '=' in the
{{@Command}} description arg.
* {{streaming_socket_timeout}} got converted to a {{Long}}, but it's being cast
to an {{int}} in {{DefaultConnectionFactory}}. Seems like it should remain an
int, with overflow checking in {{NodeProbe#setTimeout()}}?
* What do you think about renaming "rpc" to "misc"? It's sort of used as a
catchall in the codebase for various operations, so a name like "rpc" might be
too misleading.
> Make all timeouts configurable via nodetool and jmx
> ---------------------------------------------------
>
> Key: CASSANDRA-10953
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10953
> Project: Cassandra
> Issue Type: Bug
> Reporter: Sebastian Estevez
> Assignee: Jeremy Hanna
> Labels: docs-impacting
> Fix For: 2.1.13
>
> Attachments: 10953-2.1.txt
>
>
> Specifically I was interested in being able to monitor and set
> stream_socket_timeout_in_ms from either (or both) nodetool and JMX.
> Chatting with [~thobbs] and [~jeromatron] we suspect it would also be useful
> to be able to view and edit other C* timeouts via nodetool and JMX.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
