[
https://issues.apache.org/jira/browse/CASSANDRA-10924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093890#comment-15093890
]
Andrés de la Peña edited comment on CASSANDRA-10924 at 1/12/16 1:45 PM:
------------------------------------------------------------------------
I'm attaching a second version of the patch with the suggested changes. There
are two overloaded methods to validate the index options, the original and a
new one including the base table's metadata in its signature. {{IndexMetadata}}
tries to invoke the new method and, if there is no such method, it tries to
invoke the old one. I hope you find it OK.
was (Author: adelapena):
I'm attaching a second version of the patch with the suggested changes. There
are two overloaded methods to validate the index options, the original and a
new one including the base table's metadata in its signature. {IndexMetadata}
tries to invoke the new method and, if there is no such method, it tries to
invoke the old one. I hope you find it OK.
> Pass base table's metadata to Index.validateOptions
> ---------------------------------------------------
>
> Key: CASSANDRA-10924
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10924
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL, Local Write-Read Paths
> Reporter: Andrés de la Peña
> Assignee: Andrés de la Peña
> Priority: Minor
> Labels: 2i, index, validation
> Fix For: 3.0.x, 3.x
>
> Attachments: CASSANDRA-10924-v0.diff, CASSANDRA-10924-v1.diff
>
>
> Some custom index implementations require the base table's metadata to
> validate their creation options. For example, the options of these
> implementations can contain information about which base table's columns are
> going to be indexed and how, so the implementation needs to know the
> existence and the type of the columns to be indexed to properly validate.
> The attached patch proposes to add base table's {{CFMetaData}} to Index'
> optional static method to validate the custom index options:
> {{public static Map<String, String> validateOptions(CFMetaData cfm,
> Map<String, String> options);}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
