[
https://issues.apache.org/jira/browse/CASSANDRA-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105478#comment-15105478
]
Sam Tunnicliffe commented on CASSANDRA-8103:
--------------------------------------------
Thanks, v2 is mostly fine, just a couple of comments:
* {{filterStaleEntries}} still takes an unused {{partitionKey}} argument
* {{SecondaryIndexOnStaticColumnTest::testRegularColumn}} isn't related to
regular columns, but is concerned with static column. Could you rename it
please.
* In {{StatementRestrictions.hasNonPrimaryRegularColumnsRestriction}} &
associated getter, the {{NonPrimary}} is redundant.
* Could you remove the {{@Override}} annotations you added as per the [coding
style guide|https://wiki.apache.org/cassandra/CodeStyle]
> Secondary Indices for Static Columns
> ------------------------------------
>
> Key: CASSANDRA-8103
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8103
> Project: Cassandra
> Issue Type: New Feature
> Components: CQL
> Reporter: Ron Cohen
> Assignee: Taiyuan Zhang
> Fix For: 3.x
>
> Attachments: 8103-v2.patch, 8103.patch, in_progress.patch,
> smoke-test.cql
>
>
> We should add secondary index support for static columns.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
