[
https://issues.apache.org/jira/browse/CASSANDRA-10907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107351#comment-15107351
]
Paulo Motta commented on CASSANDRA-10907:
-----------------------------------------
Looking better. A few more nits:
* Rename {{skipflush}} option to {{skipFlush}} (camelCase)
* remove skipFlush from takeMultipleTableSnapshot javadoc
* add @Deprecated annotation to old methods (in addition to @deprecated javadoc)
* in javadoc {{@link #takeSnapshot..}} replace {{Map<String,String>}} with
{{Map}} (generics is not supported in javadoc link)
* Add options to message: {{Requested creating snapshot(s) for
\[keyspace1.standard1,keyspace1.counter1\] with snapshot name \[1453233210025\]
and options \{skipFlush=false\}.}}
* Fix broken test
{{org.apache.cassandra.service.StorageServiceServerTest.testTableSnapshot}}
* Improve nodetool option description from {{Skip blocking flush of the
memtable}} to {{Do not flush memtables before snapshotting (snapshot will not
contain unflushed data)}}
bq. I did add a Boolean to detect if KS / CF was passed to the proposed
signature to make things easy.
I still find it a bit redudant, since it's possible to replace the keyspaces
boolean with {{entities\[0\].contains(".")}}, and in the future we can simplify
the snapshot command to accept an arbitrary list of mixed keyspaces and/or
tables, so I'd prefer to not have this boolean.
||trunk||
|[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-10907]|
|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-10907-testall/lastCompletedBuild/testReport/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-10907-dtest/lastCompletedBuild/testReport/]|
> Nodetool snapshot should provide an option to skip flushing
> -----------------------------------------------------------
>
> Key: CASSANDRA-10907
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10907
> Project: Cassandra
> Issue Type: Improvement
> Components: Configuration
> Environment: PROD
> Reporter: Anubhav Kale
> Priority: Minor
> Labels: lhf
> Attachments: 0001-Skip-Flush-for-snapshots.patch,
> 0001-Skip-Flush-option-for-Snapshot.patch, 0001-flush.patch
>
>
> For some practical scenarios, it doesn't matter if the data is flushed to
> disk before taking a snapshot. However, it's better to save some flushing
> time to make snapshot process quick.
> As such, it will be a good idea to provide this option to snapshot command.
> The wiring from nodetool to MBean to VerbHandler should be easy.
> I can provide a patch if this makes sense.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
