[
https://issues.apache.org/jira/browse/CASSANDRA-9472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114716#comment-15114716
]
Stefania commented on CASSANDRA-9472:
-------------------------------------
It looks good [~Benedict], just a few comments / questions:
* Did you mean to override {{deletionInfo()}} in {{AtomicBTreePartition}}? I've
removed it in the nits below.
* Looking at [the last
commit|https://github.com/belliottsmith/cassandra/commit/38c50e5aa19828ee38d9a911246f526f3968db4a],
is it necessary to make a local copy of {{this.peer}}? It's a final field
initialized in the constructor so why the copy?
* I've pushed some nits
[here|https://github.com/stef1927/cassandra/commit/ea4349ef646e6ba7bd3f55069f61f6d9a5e68725]
where I also removed some code that became unnecessary following your rejig.
We need to rerun all the unit and dtests as I've not launched anything on
Jenkins with my changes. I would also rebase since tests are being fixed on an
ongoing basis. How do you run the tests given that you've changed
cassandra.yaml to use {{heap_buffers}} again? I was planning on changing this
back after we've verified all tests are OK. I believe test eng have dedicated
jobs for this but I don't think we can run them on our dev branches; hence I
had temporarily changed cassandra.yaml to use offheap objects. Or is there a
way to do this when launching the job on cassci?
> Reintroduce off heap memtables
> ------------------------------
>
> Key: CASSANDRA-9472
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9472
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Benedict
> Assignee: Benedict
> Fix For: 3.x
>
>
> CASSANDRA-8099 removes off heap memtables. We should reintroduce them ASAP.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
