[
https://issues.apache.org/jira/browse/CASSANDRA-10819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131358#comment-15131358
]
DOAN DuyHai edited comment on CASSANDRA-10819 at 2/3/16 11:27 PM:
------------------------------------------------------------------
Some remark after code review:
{code:java}
private static String javaSourceName(TypeToken<?> type)
{
String n = type.toString();
return n.startsWith("java.lang.") ?
n.substring("java.lang.".length()) : n;
}
{code}
rather {code}n.replaceAll("java\\.lang\\.",""){code} ? Because now with the
generics kept, we can have *java.lang.Map<java.lang.String, java.lang.Integer>*
Otherwise LGTM
was (Author: doanduyhai):
Some remark after code review:
{code:java}
private static String javaSourceName(TypeToken<?> type)
{
String n = type.toString();
return n.startsWith("java.lang.") ?
n.substring("java.lang.".length()) : n;
}
{code}
rather {code}n.replaceAll("java\\.lang\\.",""){code} ?
> Generic Java UDF types
> ----------------------
>
> Key: CASSANDRA-10819
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10819
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL
> Reporter: Robert Stupp
> Assignee: Robert Stupp
> Priority: Minor
> Labels: UDF, doc-impacting
> Fix For: 3.x
>
>
> At the moment we only generate raw type signatures for Java UDF methods. E.g.
> a CQL argument type {{map<int, text>}} is just mapped to {{java.util.Map}}
> but could be mapped to {{java.util.Map<Integer, String>}}.
> It's a probably simple but nice improvement and feels to be a LHF.
> Depending on the complexity it might be doable for 3.0.x, too.
> Thanks for the heads-up, [~doanduyhai]!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
