[ 
https://issues.apache.org/jira/browse/CASSANDRA-11113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134422#comment-15134422
 ] 

Marcus Eriksson commented on CASSANDRA-11113:
---------------------------------------------

+1, will commit with a small change (we need to filter suspect sstables) once 
CI completes:

||branch||testall||dtest||
|[blake/11113|https://github.com/krummas/cassandra/tree/blake/11113]|[testall|http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-blake-11113-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-blake-11113-dtest]|
|[blake/11113-2.2|https://github.com/krummas/cassandra/tree/blake/11113-2.2]|[testall|http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-blake-11113-2.2-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-blake-11113-2.2-dtest]|
|[blake/11113-3.0|https://github.com/krummas/cassandra/tree/blake/11113-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-blake-11113-3.0-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-blake-11113-3.0-dtest]|
|[blake/11113-trunk|https://github.com/krummas/cassandra/tree/blake/11113-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-blake-11113-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-blake-11113-trunk-dtest]|

> DateTieredCompactionStrategy.getMaximalTask compacts repaired and unrepaired 
> sstables together
> ----------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11113
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11113
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>              Labels: dtcs
>             Fix For: 3.0.x
>
>
> [DateTieredCompactionStrategy.getMaximalTask|https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/compaction/DateTieredCompactionStrategy.java#L393-393]
>  creates a compaction task for all of a tables sstables, instead of just the 
> repaired/unrepaired subset it's responsible for.
> This compacts repaired and unrepaired sstables together, effectively demoting 
> repaired data to unrepaired. Also, since both the repaired and unrepaired 
> strategy instances are trying to  compact the same sstables, there's a 1 
> minute delay waiting for {{CompactionManager.waitForCessation}} to time out 
> before anything happens. 
> Here's the script I used to duplicate: 
> https://gist.github.com/bdeggleston/324f4f0df1b7273d8fd5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to