[
https://issues.apache.org/jira/browse/CASSANDRA-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139782#comment-15139782
]
Tyler Hobbs commented on CASSANDRA-11048:
-----------------------------------------
[~sbtourist] thank you for the careful review. I've pushed a second commit to
address your comments. Since the previous test runs look good and this commit
only changes the test behavior, I haven't started a second round of tests.
bq. Other than that, on a more general note, the method might have been tested
in isolation via an actual unit test that only verifies the quoted string is
not messed up, without having to create tables and rows, but I see the rest of
the test class is made like that, so I will not object.
The test is still quite fast to execute, and I prefer the extra (future) safety
of testing the full stack here, so I went with the integration test approach.
> JSON queries are not thread safe
> --------------------------------
>
> Key: CASSANDRA-11048
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11048
> Project: Cassandra
> Issue Type: Bug
> Reporter: Sergio Bossa
> Assignee: Tyler Hobbs
> Priority: Critical
> Labels: easyfix, newbie, patch
> Attachments:
> 0001-Fix-thread-unsafe-usage-of-JsonStringEncoder-see-CAS.patch
>
>
> {{org.apache.cassandra.cql3.Json}} uses a shared instance of
> {{JsonStringEncoder}} which is not thread safe (see 1), while
> {{JsonStringEncoder#getInstance()}} should be used (see 2).
> As a consequence, concurrent {{select JSON}} queries often produce wrong
> (sometimes unreadable) results.
> 1.
> http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.jackson/jackson-core-asl/1.9.2/org/codehaus/jackson/io/JsonStringEncoder.java
> 2.
> http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.jackson/jackson-core-asl/1.9.2/org/codehaus/jackson/io/JsonStringEncoder.java#JsonStringEncoder.getInstance%28%29
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
