[
https://issues.apache.org/jira/browse/CASSANDRA-10876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167191#comment-15167191
]
Sylvain Lebresne commented on CASSANDRA-10876:
----------------------------------------------
The patch works, though 1) we can remove the call to {{verifyBatchSize}} in
{{CQL3CasRequest}} since by definition its always on a single mutation and 2)
it bothered me that we had to iterate on the updates to compute their number
when we initially have a collection of mutations on hand. So I've pushed a
alternative version that fix those nits:
|| [trunk|https://github.com/pcmanus/cassandra/commits/10876] ||
[utest|http://cassci.datastax.com/job/pcmanus-10876-testall/] ||
[dtest|http://cassci.datastax.com/job/pcmanus-10876-dtest/] ||
The patch is against trunk since that's where this should go really.
[~pmcfadin] still interested in reviewing?
> Alter behavior of batch WARN and fail on single partition batches
> -----------------------------------------------------------------
>
> Key: CASSANDRA-10876
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10876
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Patrick McFadin
> Priority: Minor
> Labels: lhf
> Attachments: 10876.txt
>
>
> In an attempt to give operator insight into potentially harmful batch usage,
> Jiras were created to log WARN or fail on certain batch sizes. This ignores
> the single partition batch, which doesn't create the same issues as a
> multi-partition batch.
> The proposal is to ignore size on single partition batch statements.
> Reference:
> [CASSANDRA-6487|https://issues.apache.org/jira/browse/CASSANDRA-6487]
> [CASSANDRA-8011|https://issues.apache.org/jira/browse/CASSANDRA-8011]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
