[
https://issues.apache.org/jira/browse/CASSANDRA-10971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195040#comment-15195040
]
Benjamin Lerer commented on CASSANDRA-10971:
--------------------------------------------
[~aweisberg] Sorry, I missed the lat ticket updates.
I am +1 on the patch. I am only having an issue with
{{org.apache.cassandra.db.commitlog.CommitLogTest.replay_Encrypted}} it always
timeout on CI and fail on my machine. I do not think that the patch is the
reason for the problem but I will be more confident if the test was passing.
Does it work on your machine?
> Compressed commit log has no backpressure and can OOM
> -----------------------------------------------------
>
> Key: CASSANDRA-10971
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10971
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths
> Reporter: Ariel Weisberg
> Assignee: Ariel Weisberg
> Fix For: 3.0.x, 3.x
>
>
> I validated this via a unit test that slowed the ability of the log to drain
> to the filesystem. The compressed commit log will keep allocating buffers
> pending compression until it OOMs.
> I have a fix that am not very happy with because the whole signal a thread to
> allocate a segment that depends on a resource that may not be available
> results in some obtuse usage of {{CompleatableFuture}} to rendezvous
> available buffers with {{CommitLogSegmentManager}} thread waiting to finish
> constructing a new segment. The {{CLSM}} thread is in turn signaled by the
> thread(s) that actually wants to write to the next segment, but aren't able
> to do it themselves.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
