[
https://issues.apache.org/jira/browse/CASSANDRA-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223834#comment-15223834
]
Marcus Eriksson commented on CASSANDRA-10805:
---------------------------------------------
Wanted to run all tests with the logging default to on, but I get this on
startup:
{code}
java.lang.NullPointerException
at
org.apache.cassandra.db.compaction.CompactionStrategyManager.getStrategyFolders(CompactionStrategyManager.java:674)
at
org.apache.cassandra.db.compaction.CompactionLogger.startStrategy(CompactionLogger.java:172)
at
org.apache.cassandra.db.compaction.CompactionLogger.lambda$compactionStrategyMap$1(CompactionLogger.java:126)
at java.util.ArrayList.forEach(ArrayList.java:1249)
at
org.apache.cassandra.db.compaction.CompactionLogger.lambda$forEach$0(CompactionLogger.java:120)
at java.util.Arrays$ArrayList.forEach(Arrays.java:3880)
at
org.apache.cassandra.db.compaction.CompactionLogger.forEach(CompactionLogger.java:120)
at
org.apache.cassandra.db.compaction.CompactionLogger.compactionStrategyMap(CompactionLogger.java:126)
at
org.apache.cassandra.db.compaction.CompactionLogger.startStrategies(CompactionLogger.java:213)
at
org.apache.cassandra.db.compaction.CompactionLogger.enable(CompactionLogger.java:221)
at
org.apache.cassandra.db.compaction.CompactionStrategyManager.startup(CompactionStrategyManager.java:150)
at
org.apache.cassandra.db.compaction.CompactionStrategyManager.reload(CompactionStrategyManager.java:246)
at
org.apache.cassandra.db.compaction.CompactionStrategyManager.<init>(CompactionStrategyManager.java:86)
at
org.apache.cassandra.db.ColumnFamilyStore.<init>(ColumnFamilyStore.java:408)
at
org.apache.cassandra.db.ColumnFamilyStore.<init>(ColumnFamilyStore.java:367)
at
org.apache.cassandra.db.ColumnFamilyStore.createColumnFamilyStore(ColumnFamilyStore.java:577)
at
org.apache.cassandra.db.ColumnFamilyStore.createColumnFamilyStore(ColumnFamilyStore.java:554)
at org.apache.cassandra.db.Keyspace.initCf(Keyspace.java:383)
at org.apache.cassandra.db.Keyspace.<init>(Keyspace.java:320)
at org.apache.cassandra.db.Keyspace.open(Keyspace.java:130)
at org.apache.cassandra.db.Keyspace.open(Keyspace.java:107)
at
org.apache.cassandra.db.SystemKeyspace.checkHealth(SystemKeyspace.java:889)
at
org.apache.cassandra.service.StartupChecks$8.execute(StartupChecks.java:297)
at
org.apache.cassandra.service.StartupChecks.verify(StartupChecks.java:106)
at
org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:169)
at
org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:551)
at
org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:680)
{code}
other than that, code LGTM
> Additional Compaction Logging
> -----------------------------
>
> Key: CASSANDRA-10805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10805
> Project: Cassandra
> Issue Type: New Feature
> Components: Compaction, Observability
> Reporter: Carl Yeksigian
> Assignee: Carl Yeksigian
> Priority: Minor
> Fix For: 3.x
>
>
> Currently, viewing the results of past compactions requires parsing the log
> and looking at the compaction history system table, which doesn't have
> information about, for example, flushed sstables not previously compacted.
> This is a proposal to extend the information captured for compaction.
> Initially, this would be done through a JMX call, but if it proves to be
> useful and not much overhead, it might be a feature that could be enabled for
> the compaction strategy all the time.
> Initial log information would include:
> - The compaction strategy type controlling each column family
> - The set of sstables included in each compaction strategy
> - Information about flushes and compactions, including times and all involved
> sstables
> - Information about sstables, including generation, size, and tokens
> - Any additional metadata the strategy wishes to add to a compaction or an
> sstable, like the level of an sstable or the type of compaction being
> performed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
