[
https://issues.apache.org/jira/browse/CASSANDRA-11402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235522#comment-15235522
]
Joel Knighton commented on CASSANDRA-11402:
-------------------------------------------
Hey Ryan, this definitely looks like the right idea, but my main reservation is
that it duplicates some functionality we almost already have.
Inside the org.apache.cassandra.tools.nodetool.formatter package, there's a
TableBuilder used to output tables for some other nodetool commands. I think it
would be great to reuse this in printing the table for tpstats.
We also should fix the output of this table in
org.apache.cassandra.utils.StatusLogger - to do so, we probably should bring
the TableBuilder in from nodetool-descended packages and add it to something
like FBUtilities instead.
Would you be interested in switching your patch to this approach?
> Alignment wrong in tpstats output for PerDiskMemtableFlushWriter
> ----------------------------------------------------------------
>
> Key: CASSANDRA-11402
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11402
> Project: Cassandra
> Issue Type: Bug
> Reporter: Joel Knighton
> Assignee: Ryan Magnusson
> Priority: Trivial
> Labels: lhf
> Attachments: 11402-trunk.txt
>
>
> With the accompanying designation of which memtableflushwriter it is, this
> threadpool name is too long for the hardcoded padding in tpstats output.
> We should dynamically calculate padding so that we don't need to check this
> every time we add a threadpool.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
