[
https://issues.apache.org/jira/browse/CASSANDRA-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236750#comment-15236750
]
Alex Petrov commented on CASSANDRA-10624:
-----------------------------------------
I've made the suggested changes. Although the patch got a bit bigger now. Also
would need a full review again...
* all the queries are now just parsed in {{Builder}} and saved until the
{{build()}} is called. This allows one to give the query, createType statement
and schema out of order. User still would have to take care of providing types
in the order of their creation if they depend on one another.
* {{syncrhonised}} block is there because of possible concurrent calls to
get/set metadata for keyspace. It previously surrounded only {{withTable}}, and
now is only required in {{build}} block
* test for the dependent UDTs added
|*branch*|*testall*|*dtest*|
|[trunk|https://github.com/ifesdjeen/cassandra/tree/10624-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-10624-trunk-testall/]|[dtest|http://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-10624-trunk-dtest/]|
Waiting for the CI results.
> Support UDT in CQLSSTableWriter
> -------------------------------
>
> Key: CASSANDRA-10624
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10624
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL
> Reporter: Sylvain Lebresne
> Assignee: Alex Petrov
> Fix For: 3.x
>
> Attachments: 0001-Add-support-for-UDTs-to-CQLSStableWriter.patch,
> 0001-Support-UDTs-in-CQLSStableWriterV2.patch
>
>
> As far as I can tell, there is not way to use a UDT with {{CQLSSTableWriter}}
> since there is no way to declare it and thus {{CQLSSTableWriter.Builder}}
> knows of no UDT when parsing the {{CREATE TABLE}} statement passed.
> In terms of API, I think the simplest would be to allow to pass types to the
> builder in the same way we pass the table definition. So something like:
> {noformat}
> String type = "CREATE TYPE myKs.vertex (x int, y int, z int)";
> String schema = "CREATE TABLE myKs.myTable ("
> + " k int PRIMARY KEY,"
> + " s set<vertex>"
> + ")";
> String insert = ...;
> CQLSSTableWriter writer = CQLSSTableWriter.builder()
> .inDirectory("path/to/directory")
> .withType(type)
> .forTable(schema)
> .using(insert).build();
> {noformat}
> I'll note that implementation wise, this might be a bit simpler after the
> changes of CASSANDRA-10365 (as it makes it easy to passe specific types
> during the preparation of the create statement).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
